Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2392: Use ./ as base for Vite #2396

Merged
merged 1 commit into from
Apr 8, 2024
Merged

GH-2392: Use ./ as base for Vite #2396

merged 1 commit into from
Apr 8, 2024

Conversation

kinow
Copy link
Member

@kinow kinow commented Apr 7, 2024

GitHub issue resolved #2392

Pull request Description:

Use ./ for Vite.


  • Tests are included. (covered by existing tests)
  • Documentation change and updates are provided for the Apache Jena website
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

@kinow kinow marked this pull request as ready for review April 7, 2024 22:00
@kinow
Copy link
Member Author

kinow commented Apr 7, 2024

unit and e2e tests passed. Tested with yarn dev and it works fine for default installation. Pending a test with a different base.

@kinow kinow self-assigned this Apr 7, 2024
@kinow kinow marked this pull request as draft April 7, 2024 22:01
@kinow kinow marked this pull request as ready for review April 8, 2024 13:34
@kinow
Copy link
Member Author

kinow commented Apr 8, 2024

Tested by user in the linked issue. Ready for review.

@kinow kinow requested a review from afs April 8, 2024 13:35
@afs afs merged commit e1e9bf4 into main Apr 8, 2024
@afs afs deleted the gh-2392 branch April 8, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a Fuseki Jetty server behind an Apache HTTPd proxy-pass
3 participants